https://bugzilla.redhat.com/show_bug.cgi?id=1426965
Athos Ribeiro <athoscribeiro(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review Request: |Review Request: go-i18n -
|golang-github-nicksnyder-go |Translate Go programs into
|-i18n - Translate Go |multiple languages
|programs into multiple |
|languages |
--- Comment #5 from Athos Ribeiro <athoscribeiro(a)gmail.com> ---
Hello Fabio,
Thank you for the nice review!
1) Done.
2) Upstream names the project go-i18n, but names the main binary goi18n. I will
follow the guidelines, naming the package after upstream (go-i18n).
3) Done.
4) Done.
5) Done.
6) Done.
7) Done.
8) The codegen subpackage aims the generations of source code for new locales.
I do believe this should not be shipped, but sources are shipped within the
devel subpackage. I decided to keep the comments on the binary so if anyone
ever feels that The binary should be shipped, all we'd need to do is remove the
comments. I just added a new macro to build with codegen (deactivated) and some
comments on it.
Spec URL:
https://athoscr.fedorapeople.org/packaging/go-i18n.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/go-i18n-1.7.0-4.fc25.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component