[Bug 2099902] Review Request: python-sphinx-design - Sphinx extension for responsive web components

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 --- Comment #3 from Jerry James <loganjerry(a)gmail.com&gt; --- Thank you for the unofficial review, Benson. Here are my (not completely satisfactory) answers to your questions. (In reply to Benson Muite from comment #2) When the python dist-info is assembled, it includes the LICENSE file. You can see it in the binary RPM under this path: /usr/lib/python3.10/site-packages/sphinx_design-0.2.0.dist-info/LICENSE Miro has been telling people that adding the license file under %license as well is redundant, so I left it out of this package. However, it should be included in the docs subpackage. I will fix that. ??? There is a python-sphinx-design-docs package, exactly the one that contains 61 files, in fact. This will be fixed in the next version. It is documented, in the comment just above the License field. I am unaware of any bundled libraries. Which ones did you find? Yes, and I'm even the maintainer of that package. :-) Here's the thing: the JSON versions of the icons are not in the source package. There are SVG icons in the source package that appear to be the source of the data in the JSON icons in this package. I assume that there is some SVG-to-JSON converter, but I know very little about fonts and certainly do not know anything about such a tool. The font guidelines (https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/) say that the SVG icons are not to be installed, but do give latitude for installing JSON files. If anybody reading this knows what to do, we can modify the material-icons-fonts package to include the JSON files and unbundle them from this package. In that case, I would also be willing to package octicons and do the same unbundling. Even better would be if somebody who knows what they are doing submits octicons for review. :-) Yes, the comment above the License field says so. Good point. I will add a comment above the License field in the docs subpackage. See explanation above. If the SVG-to-JSON hurdle can be overcome, then yes. The spec file uses the approved python macro, %pyproject_install, to do the installation. If it doesn't preserve timestamps when it should, that is out of my hands. Because it doesn't seem to do anything. This runs with no noticeable delay: ``` + /usr/bin/python3 -m tox --current-env -q --recreate -e py311 ___________________________________ summary ____________________________________ py311: commands succeeded congratulations :) ``` as opposed to using %pytest, which takes several seconds and prints meaningful output. New URLs (although that doesn't matter, since this bug is closed): Spec URL: https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design... SRPM URL: https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2099902