https://bugzilla.redhat.com/show_bug.cgi?id=2099902 --- Comment #2 from Benson Muite <benson_muite(a)emailplus.org&gt; --- Unofficial Review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2088960 bytes in 61 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License", "Apache License 2.0". 156 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/python-sphinx- design/2099902-python-sphinx-design/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [?]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-sphinx-design , python-sphinx-design-docs [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/executablebooks/sphinx-design/archive/v0.2.0/sphinx-de... : CHECKSUM(SHA256) this package : 901f156d7a799ab39118d3daba5fbe606844bbc2b4dda852855b508ad72eb6ad CHECKSUM(SHA256) upstream package : 901f156d7a799ab39118d3daba5fbe606844bbc2b4dda852855b508ad72eb6ad Requires -------- python3-sphinx-design (rpmlib, GLIBC filtered): (python3.10dist(sphinx) < 6~~ with python3.10dist(sphinx) >= 4) python(abi) python-sphinx-design-docs (rpmlib, GLIBC filtered): Provides -------- python3-sphinx-design: python-sphinx-design python3-sphinx-design python3.10-sphinx-design python3.10dist(sphinx-design) python3dist(sphinx-design) python-sphinx-design-docs: python-sphinx-design-docs Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2099902 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Ocaml, C/C++, SugarActivity, Haskell, Java, fonts, PHP, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: 1) Material icons seem to be available as a package https://src.fedoraproject.org/rpms/material-icons-fonts but are bundled with this installation. Can the material-icons-fonts package be updated so that bundling is not needed? 2) Material icons are under Apache Software License 3) Documentation contains javascript files which may also have different licenses 4) License file seems not to be packaged 5) Can octicons https://github.com/primer/octicons be packaged separately instead of using a bundled library? 6) Timestamps are preserved for documentation, but not for the python files 7) Why not use tox to run the tests? https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tox -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 Miro Hrončok <mhroncok(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok(a)redhat.com --- Comment #4 from Miro Hrončok <mhroncok(a)redhat.com&gt; --- From tox configuration: -------------------------------------- [testenv] usedevelop = true [testenv:py{37,38,39,310}] description = Run unit tests with this Python version extras = testing deps = black flake8~=3.8 flake8-bugbear~=21.3 commands = pytest {posargs} -------------------------------------- In other words, the py311 environment runs no commands. I consider this way of hardcoding some Python versions a bit unfortunate. However, I don't understand what was the idea here, or why the default testenv has no commands :/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 Karolina Surma <ksurma(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ksurma(a)redhat.com --- Comment #6 from Karolina Surma <ksurma(a)redhat.com&gt; --- I believe the included in the build RPM files should be also marked as %license: /usr/lib/python3.11/site-packages/sphinx_design/compiled/octicon_LICENSE /usr/lib/python3.11/site-packages/sphinx_design/compiled/material-icons_LICENSE Out of sheer curiosity, why is html/.doctrees folder kept while .buildinfo removed? I mostly see both of them removed as a result of docs build. Semantic nit-pick: Could the documentation build take place in %build instead of %prep? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 --- Comment #8 from Karolina Surma <ksurma(a)redhat.com&gt; --- I ran the fedora-review on the newest version and I've got the same notice, it seems to have come from the subpackage being "-docs" rather than "-doc" which automation looks for. I think it should be renamed for consistency with the rest of Fedora's packages and the Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_separate_docu... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 Mattias Ellert <mattias.ellert(a)physics.uu.se&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|DUPLICATE |--- Keywords| |Reopened --- Comment #10 from Mattias Ellert <mattias.ellert(a)physics.uu.se&gt; --- In bug 2099411 comment 3 Elliot writes: "I actually think Jerry did a more thorough job than I did." So I think we can take this as an agreement to do the swap and continue with this one. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 --- Comment #12 from Jerry James <loganjerry(a)gmail.com&gt; --- Huh, I didn't realize that "doc" versus "docs" matters. I've made that change, and also converted all of the license info over to SPDX. Any instances of "MIT" now refer to the SPDX identifier of that name. New URLs: Spec URL: https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design... SRPM URL: https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 --- Comment #14 from Jerry James <loganjerry(a)gmail.com&gt; --- The correct conjunction is now used in SPDX expressions. New URLs: Spec URL: https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design... SRPM URL: https://jjames.fedorapeople.org/python-sphinx-design/python-sphinx-design... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 --- Comment #16 from Jerry James <loganjerry(a)gmail.com&gt; --- Thank you very much, Karolina. I appreciate you sticking with this review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 Jerry James <loganjerry(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Fixed In Version| |python-sphinx-design-0.2.0- | |5.fc37 Last Closed|2022-06-22 11:42:11 |2022-08-02 19:54:46 --- Comment #18 from Jerry James <loganjerry(a)gmail.com&gt; --- The package has been built in Rawhide. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2099902

https://bugzilla.redhat.com/show_bug.cgi?id=2099902 --- Comment #20 from Jerry James <loganjerry(a)gmail.com&gt; --- No problem. To punish you for your sins, I've made you comaintainer. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2099902