On Thu, Aug 16, 2012 at 03:47:20PM +0200, Thorsten Kukuk wrote:
On Wed, Aug 15, Dmitry V. Levin wrote:
> On Wed, Aug 15, 2012 at 04:16:27PM +0200, Thorsten Kukuk wrote:
> > On Wed, Aug 15, Tomas Mraz wrote:
> >
> > > I think that you can workaround it in pam_namespace source.
> > >
> > > Basically include sys/mount.h (there the MS_SLAVE is in current glibc
> > > sources) and if the MS_SLAVE is not defined try to include also
> > > linux/fs.h.
> >
> > To include linux/fs.h is a bad idea, I added now a define if it is
> > not defined.
> >
> > Else I made some docu/comment changes.
> >
> > Ok to commit?
>
> OK for me, but there is a little inconsistency: in a similar case MS_REC
> was defined in pam_namespace.h instead of pam_namespace.c; since
> sys/mount.h is included in pam_namespace.h, I suggest to add a workaround
> for missing MS_SLAVE definition to the same file that includes
> sys/mount.h, i.e. to pam_namespace.h.
You are right, I changed that.
Could you push the change, please?
--
ldv