On Tue, 2019-12-17 at 01:28 +0300, Dmitry V. Levin wrote:
On Mon, Dec 16, 2019 at 10:51:27AM +0100, Tomas Mraz wrote:
> On Sat, 2019-12-14 at 12:04 +0300, Dmitry V. Levin wrote:
[...]
> > The rest of the change looks OK, although I haven't checked
> > whether
> > it suppresses *all* warnings.
>
> It does for me for -Wall -Wextra with gcc-9.2.1. However I did not
> try
> to disable features that are disablable via configure and compile
> without them.
Since we have travis enabled, I've looked into the logs.
There are still quite a few warnings reported by gcc-9.2.1:
That's strange. Why I do not see them when building the code with the
same compiler locally. Could it be something different in glibc
headers?
../../../libpam/pam_modutil_searchkey.c:116:7: warning: assignment
discards ‘const’ qualifier from pointer target type [-Wdiscarded-
qualifiers]
../../../../modules/pam_env/pam_env.c:702:46: warning: cast discards
‘const’ qualifier from pointer target type [-Wcast-qual]
../../../../modules/pam_filter/pam_filter.c:636:10: warning: to be
safe all intermediate pointers in cast from ‘char **’ to ‘const char
**’ must be ‘const’ qualified [-Wcast-qual]
../../../../modules/pam_mkhomedir/pam_mkhomedir.c:146:27: warning:
cast discards ‘const’ qualifier from pointer target type [-Wcast-
qual]
../../../../modules/pam_namespace/pam_namespace.c:2228:63: warning:
to be safe all intermediate pointers in cast from ‘void **’ to ‘const
void **’ must be ‘const’ qualified [-Wcast-qual]
../../../../modules/pam_tally2/pam_tally2.c:896:15: warning:
initialization discards ‘const’ qualifier from pointer target type [-
Wdiscarded-qualifiers]
../../../../modules/pam_tty_audit/pam_tty_audit.c:82:21: warning:
cast discards ‘const’ qualifier from pointer target type [-Wcast-
qual]
../../../../modules/pam_unix/pam_unix_acct.c:130:27: warning: cast
discards ‘const’ qualifier from pointer target type [-Wcast-qual]
../../../../modules/pam_unix/pam_unix_passwd.c:296:24: warning: cast
discards ‘const’ qualifier from pointer target type -Wcast-qual]
../../../../modules/pam_unix/support.c:529:24: warning: cast discards
‘const’ qualifier from pointer target type [-Wcast-qual]
../../../../modules/pam_unix/passverify.c:1024:20: warning: cast
discards ‘const’ qualifier from pointer target type [-Wcast-qual]
../../../../modules/pam_unix/passverify.c:1024:20: warning: cast
discards ‘const’ qualifier from pointer target type [-Wcast-qual]
../../../../modules/pam_unix/passverify.c:208:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:210:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:212:6: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:213:6: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:221:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:223:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:224:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:225:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:1024:20: warning: cast
discards ‘const’ qualifier from pointer target type [-Wcast-qual]
../../../../modules/pam_unix/passverify.c:208:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:210:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:212:6: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:213:6: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:221:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:223:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:224:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_unix/passverify.c:225:5: warning: ignoring
return value of ‘setreuid’, declared with attribute
warn_unused_result [-Wunused-result]
../../../../modules/pam_xauth/pam_xauth.c:182:18: warning: cast
discards ‘const’ qualifier from pointer target type [-Wcast-qual]
../../../tests/tst-pam_mkargv.c:21:22: warning: initialization
discards ‘const’ qualifier from pointer target type [-Wdiscarded-
qualifiers]
--
ldv
_______________________________________________
Pam-developers mailing list -- pam-developers(a)lists.fedorahosted.org
To unsubscribe send an email to
pam-developers-leave(a)lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/pam-developers@lists.fedorah...
--
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]