Re: [Pam-developers] [PATCH] Fix gratuitous use of strdup and x_strdup
On So, 2014-01-25 at 04:46 +0400, Dmitry V. Levin wrote:
There is no need to copy strings passed as arguments to execve,
the only potentially noticeable effect of using strdup/x_strdup
would be a malformed argument list in case of memory allocation error.
Also, x_strdup, being a thin wrapper around strdup, is of no benefit
when its argument is known to be non-NULL, and should not be used in
such cases.
OK, looks good.
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
(You'll never know whether the road is wrong though.)