[Pam-developers] Re: [linux-pam/linux-pam] a33d19: pam_group, pam_time: Fix logical error with multip...
On Tue, 2020-02-25 at 18:52 +0300, Dmitry V. Levin wrote:
Hi,
On Mon, Feb 24, 2020 at 10:00:14AM -0800, Tomáš Mráz wrote:
> Branch: refs/heads/master
> Home: https://github.com/linux-pam/linux-pam
> Commit: a33d198dd60d34422c706fd85d00b64d43402690
>
>
https://github.com/linux-pam/linux-pam/commit/a33d198dd60d34422c706fd85d0...
> Author: Tomas Mraz <tmraz(a)fedoraproject.org>
> Date: 2020-02-24 (Mon, 24 Feb 2020)
>
> Changed paths:
> M modules/pam_group/group.conf.5.xml
> M modules/pam_group/pam_group.c
> M modules/pam_time/pam_time.c
> M modules/pam_time/time.conf.5.xml
>
> Log Message:
> -----------
> pam_group, pam_time: Fix logical error with multiple ! operators
>
> * modules/pam_group/group.conf.5.xml: Document what logic list
> means.
> * modules/pam_time/time.conf.5.xml: Likewise.
> * modules/pam_group/pam_group.c (logic_field): Clear the not
> operator for the
> further operations.
> * modules/pam_time/pam_time.c (logic_field): Likewise.
Looks like "make distcheck" started to fail after this change.
Ah, true. & must be used. Fixed.
--
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]