Re: [Pam-developers] [PATCH 2/6] build-sys: do not overwrite CFLAGS
On Tue, Dec 09, 2014 at 03:32:09AM +0300, Dmitry V. Levin wrote:
On Mon, Aug 11, 2014 at 04:35:35PM +0200, Ronny Chevalier wrote:
> doc/specs/Makefile.am:15: warning: 'CFLAGS' is a user variable, you should
not override it;
> doc/specs/Makefile.am:15: use 'AM_CFLAGS' instead
>
> * doc/specs/Makefile.am: use AM_CFLAGS instead of overwriting CFLAGS
The patch is OK.
After the second look at this issue, I'm not sure how to fix this warning
properly: the whole idea of CC_FOR_BUILD, BUILD_CFLAGS, and BUILD_LDFLAGS
is to override CC, CFLAGS, and LDFLAGS for native compiling exceptions in
case of cross compiling.
The only place where it's necessary is doc/specs/Makefile.am.
--
ldv
Attachments:
- attachment.sig (application/pgp-signature — 181 bytes)