On Fri, Feb 10, 2012 at 07:12:51PM +0100, Tomas Mraz wrote:
On Fri, 2012-02-10 at 21:43 +0400, Dmitry V. Levin wrote:
> On Fri, Feb 03, 2012 at 04:22:19AM +0400, Dmitry V. Levin wrote:
> > On Fri, Jan 20, 2012 at 11:07:20AM +0000, Matveychikov Ilya wrote:
> > > PAM_UNIX is not able to run correctly with
'--enable-static-modules' as
> > > there are 4 pam_module structs defined: acct, auth, passwd and session.
> > > This leads to impossibility of using standart config files with things
> > > like 'auth require pam_unix.so'. So, merge all of theese structs
into
> > > the generic one -- _pam_unix_modstruct.
> >
> > What I do not quite like with this change is that it brings in more
> > redundancy and more code is going to be compiled in traditional build
> > mode. I made some tweaks to reduce that; please have a look.
>
> No objections so far? I'm not a user of either pam_unix or
> --enable-static-modules, so I'd like to get an ACK prior to committing
> this change.
I don't see that the patch would break pam_unix as a regular dynamic
module so no objections from me as I don't really care about the
--enable-static-modules.
Well, I must admit that my reason to care about --enable-static-modules
is even less than yours. :)
However, no matter how odd this mode is, --enable-static-modules was a
supported mode, and there were no public plans to deprecate it yet, so
it is a supported mode, and therefore patch submissions have to be dealt
with.
--
ldv