[Pam-developers] Re: [PATCH 00/33] Introduce pam_inline.h and use it to cleanup modules a bit
On Fri, 2020-03-20 at 15:08 +0300, Dmitry V. Levin wrote:
Hi,
On Wed, Mar 18, 2020 at 11:39:41AM +0300, Dmitry V. Levin wrote:
> This series introduces a new internal header file for definitions
> of handly inline functions and macros providing some convenient
> functionality to libpam and its modules.
>
> These macros are then used to cleanup the following coding
> patterns:
> - sizeof(x) / sizeof(*x)
> - if (!strncmp(*argv,"user_readenv=",13))
> *user_readenv = atoi(13+*argv);
> - if (strncasecmp(argv, "remember=", 9) == 0)
> options->remember = strtol(&argv[9], NULL, 10);
>
> I've also pushed the series to ldv/pam_str_skip_prefix branch
> so you can have a look at travis build logs.
Any comments?
So other than the comment about making the comparison to NULL explicit
I am OK with the patches. If you fix this, please commit.
--
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]