quarterback-devel September 2012

quarterback-devel@lists.fedorahosted.org

6 participants
14 discussions

[asalkeld/libqb] b79f8c: ipc_us: clear request unused fields

by Angus Salkeld

Branch: refs/heads/master Home: https://github.com/asalkeld/libqb Commit: b79f8ceb1e5e691906878c1c39eca7c2b5420224 https://github.com/asalkeld/libqb/commit/b79f8ceb1e5e691906878c1c39eca7c2... Author: Jeremy Fitzhardinge <jeremy(a)exablox.com> Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M lib/ipc_us.c Log Message: ----------- ipc_us: clear request unused fields Clear unused request fields and padding so that valgrind doesn't complain about undefined data being sent over the socket. Commit: 6d75ccba6f2ebff3c3485f7e2dfceeda38c62c1b https://github.com/asalkeld/libqb/commit/6d75ccba6f2ebff3c3485f7e2dfceeda... Author: Jeremy Fitzhardinge <jeremy(a)exablox.com> Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M lib/ipc_us.c Log Message: ----------- ipc_us: on Linux, set SO_PASSCRED on the sending socket too Linux doesn't pass credential information by default, only when it has been specifically requested with SO_PASSCRED. This means there's a race between when the ipc server side has set up and is listening on the socket, and when the client may connect; if the client connects and sends its first message before the server has set SO_PASSCRED on the socket, then there will be no ucred information associated with the message. The fix is to set SO_PASSCRED on the client socket as well, so that the message will always have a ucred associated with it when the server reads it. Without this change, around 1% of cpg_model_initialize() calls fail with CS_ERR_ACCESS. (This Linux behaviour was introduced just on a year ago in 16e5726269611b71c930054ffe9b858c1cea88eb "af_unix: dont send SCM_CREDENTIALS by default".) Commit: 20a707586280cf57d97e56f55fc190cf4dcde180 https://github.com/asalkeld/libqb/commit/20a707586280cf57d97e56f55fc190cf... Author: Jeremy Fitzhardinge <jeremy(a)exablox.com> Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M lib/ipc_us.c Log Message: ----------- ipc_us: slightly more robust cmsg handling Cope with multiple cmsg structures in the received msg. Commit: 3fcdb5db77d285a7594d0b716253f97888791ba6 https://github.com/asalkeld/libqb/commit/3fcdb5db77d285a7594d0b716253f978... Author: Angus Salkeld <asalkeld(a)redhat.com> Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M lib/ipc_us.c Log Message: ----------- Merge pull request #42 from jsgf/master Three fixes for ipc_us.c Compare: https://github.com/asalkeld/libqb/compare/951c9826f8a7...3fcdb5db77d2

11 years, 7 months

1
0
0 / 0

[asalkeld/libqb] 951c98: TEST: Include writing and reading the blackbox in ...

by Andrew Beekhof

Branch: refs/heads/master Home: https://github.com/asalkeld/libqb Commit: 951c9826f8a744f92329496350aaeaf10070c82b https://github.com/asalkeld/libqb/commit/951c9826f8a744f92329496350aaeaf1... Author: Andrew Beekhof <andrew(a)beekhof.net> Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M tests/check_log.c Log Message: ----------- TEST: Include writing and reading the blackbox in the log_long_msg test

11 years, 7 months

1
0
0 / 0

[asalkeld/libqb] 9d33e1: LOG: fix qb_vsnprintf_deserialize()

by Angus Salkeld

Branch: refs/heads/master Home: https://github.com/asalkeld/libqb Commit: 9d33e1f40d2622414783d4e6569a28799a7355f8 https://github.com/asalkeld/libqb/commit/9d33e1f40d2622414783d4e6569a2879... Author: Angus Salkeld <asalkeld(a)redhat.com> Date: 2012-09-05 (Wed, 05 Sep 2012) Changed paths: M lib/log_format.c Log Message: ----------- LOG: fix qb_vsnprintf_deserialize() the strlcat was not call correctly, it needs the original string to find the end and return the correct length. Signed-off-by: Angus Salkeld <asalkeld(a)redhat.com>

11 years, 7 months

1
0
0 / 0

[asalkeld/libqb] 301393: blackbox: fix 64-bit big-endian issues

by Angus Salkeld

Branch: refs/heads/master Home: https://github.com/asalkeld/libqb Commit: 30139366edcb1f00c9ff14bdeed82d3fced1a879 https://github.com/asalkeld/libqb/commit/30139366edcb1f00c9ff14bdeed82d3f... Author: Jeremy Fitzhardinge <jeremy(a)goop.org> Date: 2012-08-31 (Fri, 31 Aug 2012) Changed paths: M lib/log_blackbox.c Log Message: ----------- blackbox: fix 64-bit big-endian issues Two issues: 1. when writing out the function name length, don't just write the 4 MSB of the size 2. when reading the time, don't just use the 4 MSB of the time as the timestamp; the log contains a full time_t, so we may as well use it. Commit: 5a0bb8542b70fdf319cf2fde4fb2af83ddc5ce9d https://github.com/asalkeld/libqb/commit/5a0bb8542b70fdf319cf2fde4fb2af83... Author: Angus Salkeld <asalkeld(a)redhat.com> Date: 2012-09-01 (Sat, 01 Sep 2012) Changed paths: M lib/log_blackbox.c Log Message: ----------- Merge pull request #41 from jsgf/master Fix some 64-bit big-endian issues Compare: https://github.com/asalkeld/libqb/compare/c7810b38b193...5a0bb8542b70

11 years, 8 months

1
0
0 / 0

← Newer
1
2
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

quarterback-devel September 2012