Branch: refs/heads/master Home: https://github.com/ClusterLabs/libqb Commit: b7174544c37f631614255946eeea24006a8f6120 https://github.com/ClusterLabs/libqb/commit/b7174544c37f631614255946eeea2... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M lib/log.c Log Message: ----------- warnings cleanup: log: Wextra -> Wimplicit-fallthrough (GCC7+) See also: https://www.gnu.org/software/gcc/gcc-7/changes.html https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-f... Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: 98126363ed3f43ed44a2ec08961f691da0abf5c8 https://github.com/ClusterLabs/libqb/commit/98126363ed3f43ed44a2ec08961f6... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M include/qb/qbdefs.h M include/qb/qblog.h Log Message: ----------- warnings cleanup: Wshift-overflow: trigger arithmetic conv. to unsigned Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: aed01bb45291a4311db854f40fb01482ffca75da https://github.com/ClusterLabs/libqb/commit/aed01bb45291a4311db854f40fb01... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M lib/hdb.c M lib/loop_poll.c M lib/loop_poll_epoll.c M lib/loop_timerlist.c Log Message: ----------- maint: replace 0xffffffff constants with UNIT32_MAX Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: cfb15c7bcc5b9882e83dac7b1a6a45df38849162 https://github.com/ClusterLabs/libqb/commit/cfb15c7bcc5b9882e83dac7b1a6a4... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M lib/hdb.c M lib/loop_timerlist.c Log Message: ----------- warnings cleanup: hdb+loop_timerlist: Wsign-compare: (canary?) variables In case of hdb.c, the problem is that `check` public API (qb_hdb_handle member struct) item (which should not be exposed publicly like this in the first place!) is typed as `int32_t`, whereas it was to be compared to `uint32_t` implementation-possessed local variables (presumably derived from the same source), which made the compiler upset (even though there was no real reason, integer promotion to unsigned type would happily occur, which is furthermore expected to be fully defined as these values come from `random` that shall return non-negative integers below `INT32_MAX`). Hence: - type these local variables to `int32_t` just as well, which allows to - simplify `random` return value handling, since they are expected to be zero-or-greater and the previously extra tested all-bits-on pattern makes undoubtfully for a negative numeric value in case of a signed integer with specified width (c.f. 7.18.1.1/C99), hence falling into complement of zero-or-greater; zero itself is also excluded for the reasons stated in the comment (which was pretty hazy and incorrect, so it gets overhaul as well) - also superfluous typecasts are removed Similar situation is with loop_timerlist.c, where we are actually fully in charge of the struct member (private API), but there are good reasons to stay consistent with the former file as the same applies to the source of that value -- it comes from `random` (equivalent comment is added here for greater symmetry). Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: df3e26673844ef0c6d2d8505432f97f5b78a0581 https://github.com/ClusterLabs/libqb/commit/df3e26673844ef0c6d2d8505432f9... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M include/qb/qbarray.h M lib/array.c Log Message: ----------- maint: array: avoid magic constants, expose some in the API ... also to make it the documentation refer to the implementation limits properly. When at it, also document some nits on the implementation side, unify qbarray.h with project's doxygen conventions a bit + fix a typo there. Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: fe7a40125f2a7ef0b78159e3768161988bc306fb https://github.com/ClusterLabs/libqb/commit/fe7a40125f2a7ef0b78159e376816... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M lib/array.c Log Message: ----------- warnings cleanup: Wsign-compare: array: int32_t -> size_t Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: e893e6de59d72aefa5590dc1b33e233a6b80d9ee https://github.com/ClusterLabs/libqb/commit/e893e6de59d72aefa5590dc1b33e2... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M include/qb/qbhdb.h M lib/hdb.c Log Message: ----------- warnings cleanup: Wsign-compare: hdb: uint32_t <-> int32_t When at it, also document that qb_hdb_handle_get_always is an alias to qb_hdb_handle_get. Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: 4a7ac32fb0949184429bd49916956118bdabcd28 https://github.com/ClusterLabs/libqb/commit/4a7ac32fb0949184429bd49916956... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-20 (Wed, 20 Dec 2017) Changed paths: M lib/log_format.c Log Message: ----------- warnings cleanup: Wsign-compare: log_format: int32_t -> size_t When at it, also fix the related indentation. Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: ef5b1cf4cbb76d8e034d07b9399f6537de890dec https://github.com/ClusterLabs/libqb/commit/ef5b1cf4cbb76d8e034d07b9399f6... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-21 (Thu, 21 Dec 2017) Changed paths: M examples/ipcserver.c M examples/mapnotify.c M lib/log.c M lib/log_blackbox.c M lib/log_format.c M lib/ringbuffer.c M lib/trie.c M tests/check_ipc.c M tests/check_log.c M tests/format_compare_speed.c Log Message: ----------- warnings cleanup: Wformat: sign-correct PRIu32 specifiers as appropriate Looks like these are not accepted with splint checker. Also fix some other minor type -- print format specifier discrepancies. Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: 499a7f7ea61cf9a372469ed76bb78bed12fc9918 https://github.com/ClusterLabs/libqb/commit/499a7f7ea61cf9a372469ed76bb78... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-21 (Thu, 21 Dec 2017) Changed paths: M tests/check_ipc.c Log Message: ----------- warnings cleanup: Wunused-function: leave the test commented out ... as well as the test inclusion itself in make_soc_suite. Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: cc9f2b676e39d07e1ad0fe6232bc8a00c36fb6ee https://github.com/ClusterLabs/libqb/commit/cc9f2b676e39d07e1ad0fe6232bc8... Author: Jan Pokorný <jpokorny(a)redhat.com&gt; Date: 2017-12-21 (Thu, 21 Dec 2017) Changed paths: M configure.ac Log Message: ----------- warnings cleanup: give up on some warning classes for now Signed-off-by: Jan Pokorný <jpokorny(a)redhat.com&gt; Commit: e5530b69c2bd3b46cda2bab201ed935cd9a7ac94 https://github.com/ClusterLabs/libqb/commit/e5530b69c2bd3b46cda2bab201ed9... Author: Christine Caulfield <ccaulfie(a)redhat.com&gt; Date: 2017-12-21 (Thu, 21 Dec 2017) Changed paths: M lib/log.c Log Message: ----------- warnings cleanup: fix initialiser warning on RHEL7 Compare: https://github.com/ClusterLabs/libqb/compare/8a24f99b5359...e5530b69c2bd