Mohammed Morsi wrote:
....
Readded, though honestly I'm not a fan of this reasoning. If its
not
....
Thanks.
> I see you are still using this approach:
>
> %build
> export LIB_PREFIX=%{_lib}
>
> Using that approach causes the "make ...&& cd r*9/r*9&& make
..."
> idiom to subtly malfunction if it ends up running mkconfig.rb.
Done, changed it to use your patch.
Thanks.
Minor suggestions:
- don't add two trailing blanks via ruby-1.8.7-lib-paths.patch
You can remove just those two via e.g.,
perl -pi -e 's/(.) $/$1/' ruby-1.8.7-lib-paths.patch
- remove unused: %global sitedir2 %{ruby_sitelib}
- remove vestiges of emacs. Now that we don't distribute ruby-mode
(it's in new-enough emacs), you can remove these lines from your spec:
# emacs sitelisp directory
%{!?_emacs_sitelispdir: %global _emacs_sitelispdir %{_datadir}/emacs/site-lisp}
%{!?_emacs_sitestartdir: %global _emacs_sitestartdir
%{_datadir}/emacs/site-lisp/site-start.d}
BuildRequires: emacs