Barak Korren has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system ......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/48446/6/vdsm.spec.in File vdsm.spec.in:
Line 626: %if %{with_gluster_mgmt} == no Line 627: --disable-gluster-mgmt \ Line 628: %endif Line 629: %if %{rhev_build} == yes Line 630: --enable-hooks \
This may conflicts with hook configuration, preventing building for rhev wi
we're building it --with-hooks anyway so no need to remove this (I don't think building without hooks is a useful scenario at all, for anyone, as just not shipping specific packages is simpler then doing a specialized build) Line 631: --enable-rhev \ Line 632: --with-smbios-manufacturer='Red Hat' \ Line 633: --with-smbios-osname='RHEV Hypervisor' \ Line 634: --with-qemu-kvm='qemu-kvm-rhev' \
vdsm-patches@lists.fedorahosted.org