Change in vdsm[master]: check-merged: unbreak network functional tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: unbreak network functional tests
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d6cdea3f0f0b895ffaa7b5e829acad422b804e3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: confmeta: Add confmeta module
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: confmeta: Add confmeta module
......................................................................
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/70583/10//COMMIT_MSG
Commit Message:
Line 21: Example usage:
Line 22:
Line 23: >>> from vdsm.tool import confmeta
Line 24: >>>> confmeta.read_metadata(path)
Line 25: ConfigMetadata(revision=3, private=False)
> configfile handles ini file format, this module handle the a header in the
it seems quite related. both works on the conf files and related to configurators - it should be at the same place. don't you think?
Line 26:
Line 27: This module will be used to manage lvmlocal.conf file, and later will
Line 28: replace the system used to manage multiapth.conf.
Line 29:
--
To view, visit https://gerrit.ovirt.org/70583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[master]: confmeta: Add confmeta module
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: confmeta: Add confmeta module
......................................................................
Patch Set 10: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/70583/10//COMMIT_MSG
Commit Message:
Line 21: Example usage:
Line 22:
Line 23: >>> from vdsm.tool import confmeta
Line 24: >>>> confmeta.read_metadata(path)
Line 25: ConfigMetadata(revision=3, private=False)
we have lib/tool/configfile - which suppose to handle the same area. can you please explain why we need both? or why can't you add your logic there?
Line 26:
Line 27: This module will be used to manage lvmlocal.conf file, and later will
Line 28: replace the system used to manage multiapth.conf.
Line 29:
--
To view, visit https://gerrit.ovirt.org/70583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[master]: ssl: trust ipv6 localhost addresses
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ssl: trust ipv6 localhost addresses
......................................................................
ssl: trust ipv6 localhost addresses
compare_names trusts connections from localhost regardless of the
certificate presented by them. This should take place with ipv6 and ipv4
alike.
This patch adds ipv6 local addresses to the trusted set.
Bug-Url: https://bugzilla.redhat.com/1412550
Change-Id: I745ecfae5b095e58bfd6d3cb6004d490e1677b09
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/sslutils.py
M tests/ssl_test.py
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/70083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I745ecfae5b095e58bfd6d3cb6004d490e1677b09
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: sslutils: _compare_names: fix arg names and add tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: sslutils: _compare_names: fix arg names and add tests
......................................................................
sslutils: _compare_names: fix arg names and add tests
_compare_names needs to return True if the TCP stream originates from a
source address that matches the certificate presented by the client.
This match makes the method args clearer. Since the method does not need
to use `self` it is declared a @staticmethod. Tests are added to
document its expected behavior and make sure it is maintained in a
following patch.
Change-Id: I7faeaaee728da4f97aaa05fddf3ab2e418cb2c40
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/sslutils.py
M tests/ssl_test.py
2 files changed, 25 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/70951/1
diff --git a/lib/vdsm/sslutils.py b/lib/vdsm/sslutils.py
index c3f9560..1017ec6 100644
--- a/lib/vdsm/sslutils.py
+++ b/lib/vdsm/sslutils.py
@@ -235,11 +235,13 @@
return False
- def _compare_names(self, addr, name):
- if addr == name or addr == '127.0.0.1':
+ @staticmethod
+ def _compare_names(tcp_source, common_name):
+ if tcp_source == common_name or tcp_source == '127.0.0.1':
return True
else:
- return name.lower() == socket.gethostbyaddr(addr)[0].lower()
+ return (common_name.lower() ==
+ socket.gethostbyaddr(tcp_source)[0].lower())
def _handshake(self, dispatcher):
try:
diff --git a/tests/ssl_test.py b/tests/ssl_test.py
index b9bac99..80250ae 100644
--- a/tests/ssl_test.py
+++ b/tests/ssl_test.py
@@ -20,6 +20,7 @@
from __future__ import print_function
import errno
+import mock
import os
import re
from six.moves import xmlrpc_client as xmlrpclib
@@ -44,6 +45,7 @@
get_server_socket, KEY_FILE, \
CRT_FILE, OTHER_KEY_FILE, OTHER_CRT_FILE
_m2cEnabled = False
+from vdsm.sslutils import SSLHandshakeDispatcher
HOST = '127.0.0.1'
@@ -374,6 +376,24 @@
self.assertEqual(secondSessionId, firstSessionId)
+class CompareNameTest(TestCaseBase):
+ @mock.patch('socket.gethostbyaddr')
+ def test_same_string(self, mock_gethostbyaddr):
+ mock_gethostbyaddr.return_value = ('commonname', [], ['10.0.0.1'])
+ self.assertTrue(SSLHandshakeDispatcher._compare_names(
+ '10.0.0.1', 'commonname'))
+
+ @mock.patch('socket.gethostbyaddr')
+ def test_imposter(self, mock_gethostbyaddr):
+ mock_gethostbyaddr.return_value = ('truename', [], ['10.0.0.1'])
+ self.assertFalse(SSLHandshakeDispatcher._compare_names(
+ '10.0.0.1', 'commonname'))
+
+ def test_local_addresses(self):
+ self.assertTrue(SSLHandshakeDispatcher._compare_names(
+ '127.0.0.1', 'commonname'))
+
+
# The address of the tests server:
ADDRESS = ("127.0.0.1", 8443)
--
To view, visit https://gerrit.ovirt.org/70951
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7faeaaee728da4f97aaa05fddf3ab2e418cb2c40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 3 months
Change in vdsm[master]: ssl: trust ipv6 localhost addresses
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: trust ipv6 localhost addresses
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/70083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I745ecfae5b095e58bfd6d3cb6004d490e1677b09
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: vdsm-tool: Add lvm configurator
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Add lvm configurator
......................................................................
Patch Set 4:
(2 comments)
(not reviewed yet)
https://gerrit.ovirt.org/#/c/71231/4//COMMIT_MSG
Commit Message:
PS4, Line 9: mask
masks disables and stops
PS4, Line 20: LVM filter
please elaborate or add a url
--
To view, visit https://gerrit.ovirt.org/71231
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0e34efbcb2d8c1fac1aec3dc9e68a65957c84c2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[master]: net: modify VF MAC addresses on creation to a valid address
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: modify VF MAC addresses on creation to a valid address
......................................................................
Patch Set 28:
(3 comments)
https://gerrit.ovirt.org/#/c/71029/28//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-01-26 18:04:32 +0200
Line 6:
Line 7: api: modify VF MAC addresses on creation to a valid address
Line 8:
Line 9: igb driver forbids resetting VF MAC address back to 00:00:00:00:00:00,
> I don't think it's the responsibility of the patch/commit message to elabor
https://www.berrange.com/tags/commit-message/
Line 10: which was its original value. By setting the MAC addresses to a valid
Line 11: value (00:00:00:00:00:01, for example), upon restoration the previous address
Line 12: (which was set to be valid) will be accepted.
Line 13:
https://gerrit.ovirt.org/#/c/71029/28/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 70: time.sleep(0.5)
Line 71: udevadm.settle(timeout=10)
Line 72:
Line 73:
Line 74: def _set_valid_macs_for_igb_vfs(pci_path, numvfs):
> Done
Maybe it's done, but it is not posted yet. I prefer to have it as a follow-up, to simplify backport of the current patch. but taking this out of api.py is a noble cause.
Line 75: """ igb driver forbids resetting VF MAC address back to 00:00:00:00:00:00,
Line 76: which was its original value. By setting the MAC addresses to a valid
Line 77: value (e.g. TARGET_MAC) upon restoration the valid address will
Line 78: be accepted.
PS28, Line 75:
> Done
no it wasn't done I am afraid.
--
To view, visit https://gerrit.ovirt.org/71029
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[master]: automation: add missing python-dateutil package
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: add missing python-dateutil package
......................................................................
automation: add missing python-dateutil package
patch https://gerrit.ovirt.org/#/c/69846 added
python-dateutil to jenkins jobs but some jobs
weren't updated: check-patch-fc24 and build-artifacts-fc24
We must keep fc24 build workable until
https://gerrit.ovirt.org/#/c/71246/ is merged or our fc25 build
is otherwise fixed.
Change-Id: I69d05da1bbc906dfc8062d735fc6744bf6c06d50
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M automation/build-artifacts.packages.fc24
M automation/check-patch.packages.fc24
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69d05da1bbc906dfc8062d735fc6744bf6c06d50
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months