Change in vdsm[master]: after_disk_prepare: Add new hook point
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: after_disk_prepare: Add new hook point
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/71641/2//COMMIT_MSG
Commit Message:
Line 24: "volumeID": "143e2e28-b2bb-42d4-93c6-835368d3d0ae"
Line 25: }
Line 26: }
Line 27:
Line 28: The VM uuid is available via the vmId environment variable.
also vm-level custom properties should be.
Line 29:
Line 30: The hook is supported only when preparing images before starting a vm.
Line 31: Other flows preparing drives are not supported.
Line 32:
Line 26: }
Line 27:
Line 28: The VM uuid is available via the vmId environment variable.
Line 29:
Line 30: The hook is supported only when preparing images before starting a vm.
preparation before hot-plug of a VM should be supported as well.
Line 31: Other flows preparing drives are not supported.
Line 32:
Line 33: Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417
--
To view, visit https://gerrit.ovirt.org/71641
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[master]: tests: make vmfakelib independent from clientIF
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: make vmfakelib independent from clientIF
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/70609
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ddf3ec41fbd0aa06077441b461877f5b20f19d7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: vdsm-tool: Add lvm configurator
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: Add lvm configurator
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/71231
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0e34efbcb2d8c1fac1aec3dc9e68a65957c84c2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: migration: add boolean to control retries
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: migration: add boolean to control retries
......................................................................
migration: add boolean to control retries
We added logic to automatically retry migrations if the
destination Vdsm is over capacity.
The current logic uses the progress to learn if a retry must be
attempted.
For this purposes, it is just safer and clearer to add one new boolean
value, to be set once migration actually started.
This flag is never accessed concurrently, so we don't need a full-blown
threading.Event object.
We should never retry failed migrations without Engine's instructions,
and with the old, progress-based code, that could mistakenly happen.
With the new event-based code, we make sure this is not possible
anymore.
Change-Id: Ie45553bf3ec3db76e520d11a68c67b5b9664dc32
Related-To: https://bugzilla.redhat.com/1414626
Backport-To: 4.1
Backport-To: 4.0
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/migration.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified; Passed CI tests
Martin Polednik: Looks good to me, but someone else must approve
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie45553bf3ec3db76e520d11a68c67b5b9664dc32
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: migration: make progress reporting reliable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: migration: make progress reporting reliable
......................................................................
migration: make progress reporting reliable
The rhbz#1414626 demonstrates some issues in our current progress
handling. Since we use the progress also for logic inside the
SourceThread class, this is a more serious issue than just showing
a value.
The first issue is that we update the progress percentage in two
places: getStat(), just before reporting it, and finishSuccesfully,
to make sure the progress is 100% after migration ended (rounding
errors or missing updates may case it to stay at 99%).
Unfortunately, getStat() can run concurrently to the migration code,
so nothing prevents it from overwrite the value finishSuccessfully set.
The second issue is more complex. First let's point out that
there could be legitimate cases for progress going
backwards. If a migration is stalling because the guess is making pages
dirty too fast, the amount of data_remaining could increase.
However, because both lack of guarantees about
monotonic increase and the race on write, we could end up with
progress = 99 after migration ended, and this could mistakenly trigger
another migration attempt - which indeed happen in rhbz#1414626.
The definitive fix for this harmful retry is provided in change
Ie45553bf3ec3db76e520d11a68c67b5b9664dc32
Change-Id: I2663382b6b1b2b58f8e4980a23ace36f4736930d
Bug-Url: https://bugzilla.redhat.com/1414626
Backport-To: 4.1
Backport-To: 4.0
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/migration.py
M tests/vmmigration_test.py
2 files changed, 88 insertions(+), 7 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified; Passed CI tests
Martin Polednik: Looks good to me, but someone else must approve
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2663382b6b1b2b58f8e4980a23ace36f4736930d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: migration: add boolean to control retries
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: migration: add boolean to control retries
......................................................................
Patch Set 10: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/71160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie45553bf3ec3db76e520d11a68c67b5b9664dc32
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: migration: make progress reporting reliable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: migration: make progress reporting reliable
......................................................................
Patch Set 10: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/71159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2663382b6b1b2b58f8e4980a23ace36f4736930d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: hooks: Add localdisk hook
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add localdisk hook
......................................................................
Patch Set 9: Code-Review-1
(1 comment)
nit
https://gerrit.ovirt.org/#/c/71272/9/vdsm_hooks/Makefile.am
File vdsm_hooks/Makefile.am:
Line 47: hostusb \
Line 48: httpsisoboot \
Line 49: hugepages \
Line 50: isolatedprivatevlan \
Line 51: localdisk \
please place it in the SUBDIRS of line 21: we consider to make this a supported hook
Line 52: macbind \
Line 53: nestedvt \
Line 54: noipspoof \
Line 55: numa \
--
To view, visit https://gerrit.ovirt.org/71272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6ad8e8ebb4cd71bff02157f28cd2be5c31ac35
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 4 months
Change in vdsm[master]: confmeta: Add confmeta module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: confmeta: Add confmeta module
......................................................................
confmeta: Add confmeta module
This module handles configuration files managed by vdsm, using a
metadata comments header.
Example file:
# This file is managed by vdsm
# description...
#REVISION: 3
#PRIVATE: NO
file contents...
Example usage:
>>> from vdsm.tool import confmeta
>>>> confmeta.read_metadata(path)
ConfigMetadata(revision=3, private=False)
This module will be used to manage lvmlocal.conf file, and later will
replace the system used to manage multiapth.conf.
Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638
Bug-Url: https://bugzilla.redhat.com/1374545
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/vdsm/tool/Makefile.am
A lib/vdsm/tool/confmeta.py
M tests/Makefile.am
A tests/tool_confmeta_test.py
M vdsm.spec.in
5 files changed, 259 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Verified; Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Objections:
Yaniv Bronhaim: I would prefer that you didn't submit this
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/70583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
7 years, 4 months
Change in vdsm[ovirt-4.1]: net: vlan@bond config with ifcfg requires hwaddrs sync check
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: vlan@bond config with ifcfg requires hwaddrs sync check
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fc13f42ec21fef1e62f326981742bd66a792429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months