Change in vdsm[master]: net: Introduce bond properties and refactoring options handling
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Introduce bond properties and refactoring options handling
......................................................................
net: Introduce bond properties and refactoring options handling
Bond properties are introduced, acting as a superset of bond options.
Bond options are properties that affect bond operation and can be
modified, where the properties include the options and other
informative details (read only ones).
The existing options handling has been adjusted to fit the new
introduced properties with an aim to simplify and remove duplication.
Change-Id: I7f9fe408dabb7009e07cc487d04f32b12b0322e6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/link/bond/__init__.py
M lib/vdsm/network/link/bond/sysfs_driver.py
M lib/vdsm/network/link/bond/sysfs_options.py
M lib/vdsm/network/models.py
M lib/vdsm/network/netinfo/bonding.py
M lib/vdsm/tool/dump_bonding_opts.py
M tests/network/link_bond_test.py
M tests/network/netinfo_test.py
8 files changed, 115 insertions(+), 62 deletions(-)
Approvals:
Dominik Holler: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/71024
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f9fe408dabb7009e07cc487d04f32b12b0322e6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: net: Introduce bond properties and refactoring options handling
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce bond properties and refactoring options handling
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/71024/3/lib/vdsm/network/link/bond/sysfs_opt...
File lib/vdsm/network/link/bond/sysfs_options.py:
PS3, Line 102: _
> no need to change this to lowercase
or a test for this newly-public function
--
To view, visit https://gerrit.ovirt.org/71024
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f9fe408dabb7009e07cc487d04f32b12b0322e6
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[master]: confmeta: Add confmeta module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: confmeta: Add confmeta module
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/70583/10//COMMIT_MSG
Commit Message:
Line 21: Example usage:
Line 22:
Line 23: >>> from vdsm.tool import confmeta
Line 24: >>>> confmeta.read_metadata(path)
Line 25: ConfigMetadata(revision=3, private=False)
> This module handle lvm.conf, and should replace the code in multipath.conf.
Yaniv and Mooli, I tend to agree with Nir: his new configurator intends only to mark configuration files as "ours" or "private". It is quite distinct from editing ini files. maybe the name "configfile" is too broad. For example, multipath.conf is also a configuration file, and it is justly not handled by the configfile configurator.
Line 26:
Line 27: This module will be used to manage lvmlocal.conf file, and later will
Line 28: replace the system used to manage multiapth.conf.
Line 29:
--
To view, visit https://gerrit.ovirt.org/70583
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[ovirt-4.1]: net: Extracting SRIOV functionality
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Extracting SRIOV functionality
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71530
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaab7317b77c5d7e35a013754f7baafce6559368d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[ovirt-4.1]: net: modify VF MAC addresses on creation to a valid address
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: modify VF MAC addresses on creation to a valid address
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71529
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[ovirt-4.1]: net: Set and report device mac address through link.iface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Set and report device mac address through link.iface
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71519
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21a63a4a36252634744e7af177706403353aaab4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: net: modify VF MAC addresses on creation to a valid address
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: modify VF MAC addresses on creation to a valid address
......................................................................
net: modify VF MAC addresses on creation to a valid address
When a guest releases an SR-IOV virtual function, the virtual function's
previous MAC address is being restored in host. There is currently an
unresolved bug in igb driver's where it fails to reallocate the virtual
function back to the host as it doesn't accept the factory (00:00:00:00:00:00)
MAC address.
Until the issue is resolved on the driver level, this patch implements
a hack modifying the VF's MAC addresses on creation to valid addressess that
will be accepted upon reallocation.
Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1410076
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/network/api.py
1 file changed, 28 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71029
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679
Gerrit-PatchSet: 39
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: net: Extracting SRIOV functionality
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Extracting SRIOV functionality
......................................................................
net: Extracting SRIOV functionality
Extracting SRIOV functionality from api to a separate module.
Change-Id: Iaab7317b77c5d7e35a013754f7baafce6559368d
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/network/api.py
A lib/vdsm/network/link/sriov.py
2 files changed, 101 insertions(+), 78 deletions(-)
Approvals:
Ori Ben Sasson: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71370
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaab7317b77c5d7e35a013754f7baafce6559368d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Ori Ben Sasson <obensass(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: net: Extracting SRIOV functionality
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Extracting SRIOV functionality
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71370
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaab7317b77c5d7e35a013754f7baafce6559368d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Ori Ben Sasson <obensass(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: net: modify VF MAC addresses on creation to a valid address
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: modify VF MAC addresses on creation to a valid address
......................................................................
Patch Set 39: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71029
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679
Gerrit-PatchSet: 39
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months