Doron Fediuck has posted comments on this change.
Change subject: Change mom policy related interface to support multi-policy
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
Royce, good job! You have my ack, but there's one thing
I'd like to see changed (in this patch or later on);
errCode['momErr'] is returned for most actions / functions, with absolutely no
logging and/or some message that could help us identify issues. Both get and reset policy
in this case may end up with the same error and no clue what and why it happened.
So my requests are:
1. Consider adding meaningful error codes (momPolicyErr, momConfigErr, ..).
2. (Starting now) log every error we hit in the code.
Thanks!
Doron
--
To view, visit
http://gerrit.ovirt.org/12466
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09c40fee74b10d3eb41f4ec3ca18096a9b20dfcd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mei Liu <liumbj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server