From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sslutils: _compare_names: fix arg names and add tests
......................................................................
sslutils: _compare_names: fix arg names and add tests
_compare_names needs to return True if the TCP stream originates from a
source address that matches the certificate presented by the client.
This patch makes the method args clearer. Since the method does not need
to use `self`, it is declared a @staticmethod. Tests are added to
document its expected behavior and make sure the behavior is maintained
in a following patch.
Change-Id: I7faeaaee728da4f97aaa05fddf3ab2e418cb2c40
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/sslutils.py
M tests/ssl_test.py
2 files changed, 26 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/70951
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7faeaaee728da4f97aaa05fddf3ab2e418cb2c40
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>