Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/1/vdsm/storage/resourceManager.py
File vdsm/storage/resourceManager.py:
Line 574:
Line 575: self._log.debug("Resource '%s' is currently
locked, "
Line 576: "Entering queue (%d in queue)",
Line 577: fullName, len(resource.queue) + 1)
Line 578: ref = RequestRef(request)
i referred to line 578, if you moved it from the return statement it
seems
It seems better to keep logging before attempting to change the resource.
Line 579: resource.queue.insert(0, request)
Line 580: return ref
Line 581:
Line 582: # TODO : Creating the object inside the namespace lock causes
--
To view, visit
http://gerrit.ovirt.org/25284
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes