Dan Kenigsberg has posted comments on this change.
Change subject: Create GuestAgent instance in __init__ and connect later
......................................................................
Patch Set 5: Code-Review-1
(2 comments)
Let's not leave tautologies behind.
http://gerrit.ovirt.org/#/c/26142/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2038: return
Line 2039: with self._confLock:
Line 2040: toSave = deepcopy(self.status())
Line 2041: toSave['startTime'] = self._startTime
Line 2042: if self.lastStatus != vmstatus.DOWN and \
no need to check for self.guestAgent now - it is never None.
Line 2043: self._vmStats and self.guestAgent:
Line 2044: toSave['username'] =
self.guestAgent.guestInfo['username']
Line 2045: toSave['guestIPs'] =
self.guestAgent.guestInfo['guestIPs']
Line 2046: toSave['guestFQDN'] =
self.guestAgent.guestInfo['guestFQDN']
Line 2411: GUEST_WAIT_TIMEOUT = 60
Line 2412: now = time.time()
Line 2413: if now - self._guestEventTime < 5 * GUEST_WAIT_TIMEOUT and \
Line 2414: self._guestEvent == vmstatus.POWERING_DOWN:
Line 2415: return self._guestEvent
and here
Line 2416: if self.guestAgent and self.guestAgent.isResponsive() and \
Line 2417: self.guestAgent.getStatus():
Line 2418: return self.guestAgent.getStatus()
Line 2419: if now - self._guestEventTime < GUEST_WAIT_TIMEOUT:
--
To view, visit
http://gerrit.ovirt.org/26142
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82f7397b01bff48a3c635eee9912cc67cf722b13
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes