Bala.FA has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/taskManager.py
Line 113: taskID)
Line 114: self.log.debug("Return: %s", subRes)
Line 115: return subRes
Line 116:
Line 117: def getAllTasks(self, tag=[]):
There are two ways I see.
task.getTags() can return self.tag.split(KEY_SEPERATOR)
or
task.tag in task is list containing tags
Please suggest which one is better to do.
Line 118: """
Line 119: Return Tasks for all public tasks if param tag is empty,
Line 120: else return tasks those tags are in param tag.
Line 121: """
--
To view, visit
http://gerrit.ovirt.org/7579
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c765cbfebb5ba22f0d21efa04c824ea4daf6432
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server