Ayal Baron has posted comments on this change.
Change subject: sp: improve pool creation error handling
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/22818/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 139: and not self.spmRole == SPM_ACQUIRED):
Line 140: self.invalidateMetadata()
Line 141: poolMeta = self._getPoolMD(self.masterDomain)
Line 142:
Line 143: return poolMeta[PMDK_LVER], poolMeta[PMDK_SPM_ID]
why are you not returning the role? this changes the API
Line 144:
Line 145: def setSpmStatus(self, lVer=None, spmId=None):
Line 146: self.invalidateMetadata()
Line 147: metaParams = dict(filter(lambda (k, v): v is not None,
--
To view, visit
http://gerrit.ovirt.org/22818
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cce08e368dec092222c081609d0663d7990ab10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes