From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: (wip) Adding abrt dependency and introduce configurator for it
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/44287/4/vdsm.spec.in
File vdsm.spec.in:
Line 109: Requires: rpm-python
Line 110: Requires: nfs-utils
Line 111: Requires: m2crypto
Line 112: Requires: libnl3
Line 113: Requires: abrt-desktop
We definitely don't want to add abrt-gui and gnome-abrt as VDSM
dependency,
Done
Line 114: Requires: curl
Line 115: Requires: %{name}-xmlrpc = %{version}-%{release}
Line 116: Requires: %{name}-jsonrpc = %{version}-%{release}
Line 117: Requires: safelease >= 1.0-7
https://gerrit.ovirt.org/#/c/44287/4/vdsm/vdsm-logrotate
File vdsm/vdsm-logrotate:
Line 24
Line 25
Line 26
Line 27
Line 28
Shouldn't we rotate also abrt files or abrt does that
automatically? If so,
we will need to see while its running if its needed. im not
sure yet if it overrides reports
--
To view, visit
https://gerrit.ovirt.org/44287
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5e66c9f029be75483b86414e328d074c7e454
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes