Dan Kenigsberg has posted comments on this change.
Change subject: Always use OOP when padding snapshot's memory volume
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/26538/4//COMMIT_MSG
Commit Message:
Line 7: Always use OOP when padding snapshot's memory volume
Line 8:
Line 9: We used to use OOP when padding snapshot's memory volume only if the
Line 10: storage type was NFS. In order to determine if the storage type is NFS
Line 11: we had to call the costly (and possibly failing) getStorageDomainInfo
when is it failing? why do we want to continue with the padding if it has failed?
Line 12: method. Since other file based storage types can theoretically suffer
Line 13: from the same problems as the ones NFS suffer from, it seems safer to
Line 14: use OOP for all of them and not perform that costly call.
Line 15:
http://gerrit.ovirt.org/#/c/26538/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3725: '_srcDomXML': self._dom.XMLDesc(0),
Line 3726: 'elapsedTimeOffset': time.time() -
self._startTime}
Line 3727:
Line 3728: def _padMemoryVolume(memoryVolPath, sdUUID):
Line 3729: if not utils.isBlockDevice(memoryVolPath):
isBlockDevice() does os.stats() which may hang forever on top of NFS.
Line 3730: oop.getProcessPool(sdUUID).fileUtils. \
Line 3731: padToBlockSize(memoryVolPath)
Line 3732:
Line 3733: snap = xml.dom.minidom.Element('domainsnapshot')
--
To view, visit
http://gerrit.ovirt.org/26538
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a94354e188019f3afd209633979ec5a5b35293b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes