Change in vdsm[master]: Generalize _parseDriveSpec dictionaries.
Igor Lvovsky has posted comments on this change.
Change subject: Generalize _parseDriveSpec dictionaries.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Did we agree about changing drives interface?
If we don't, this patch is redundant.
....................................................
File vdsm_cli/vdsClient.py
Line 1341:
Line 1342: #TODO: Remove this and the references to domainID (etc) key.
Line 1343: def _splitDriveSpecItems(self, item):
Line 1344: """
Line 1345: BC is BC.
sorry, but what is BC ?
Line 1346: """
Line 1347: key, value = item.split(":", 1)
Line 1348: if key in ("domain", "pool", "image",
"volume"):
Line 1349: key = "%sID" % key
Line 1353: """
Line 1354: ',' means dict. (!)
Line 1355: """
Line 1356: if ',' in spec:
Line 1357: return dict(self._splitDriveSpecItems(item) for item in
spec.split(',') if item != "")
minor comment:
more clear will be ' if item ' instead of ' if item != "" '
Line 1358: return spec
Line 1359:
Line 1360: def do_addNetwork(self, args):
Line 1361: params = self._eqSplit(args)
--
To view, visit http://gerrit.usersys.redhat.com/1063
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24350c099a92923323a221c909c53855a2906ece
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>