Nir Soffer has posted comments on this change.
Change subject: sdm: Add find_domain_manifest helpers
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Partial review
https://gerrit.ovirt.org/#/c/43555/2/vdsm/storage/nfsSD.py
File vdsm/storage/nfsSD.py:
Line 123:
Line 124:
Line 125: def findDomainManifest(sdUUID, metadata=None):
Line 126: return fileSD.FileStorageDomainManifest(
Line 127: NfsStorageDomain.findDomainPath(sdUUID), metadata)
This formating is not clear, lets use 2 short lines instead.
path = NfsStorageDomain.findDomainPath(sdUUID)
return fileSD.FileStorageDomainManifest(path, metadata)
--
To view, visit
https://gerrit.ovirt.org/43555
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5d139bde2349c8231141fe842d9ada96fa279fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes