Nir Soffer has posted comments on this change.
Change subject: mailbox: Log traceback after fatal failures in mailbox monitors
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/29853/2/vdsm/storage/storage_mailbox.py
File vdsm/storage/storage_mailbox.py:
Line 793: self._inLock.release()
Line 794: self.log.error("Error checking for mail",
exc_info=True)
Line 795: time.sleep(self._monitorInterval)
Line 796: self.log.info("SPM_MailMonitor - Incoming mail monitoring
thread "
Line 797: "stopped")
Not sure about this one. It was handy to know explicitly in all cases
that
If the thread was aborted, we will a traceback. When logging this in finally,
we see "normal" message in abnormal branch.
So for normal stop, we will see:
INFO SPM_MailMonitor - Incoming mail monitoring thread stopped
And in abnormal situation:
ERROR Unhandled exception in SPM_MailMonitor thread
Traceback...
I can split this to another patch if you like.
Line 798: finally:
Line 799: self._stopped = True
--
To view, visit
http://gerrit.ovirt.org/29853
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68957ca745018349cae488acfe252e902c2af3ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes