Change in vdsm[master]: new API call getVersionInfo()
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: new API call getVersionInfo()
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 1524: # @software_version: VDSM version (x.y.z)
Line 1525: #
Line 1526: # @software_revision: Extra VDSM version information
Line 1527: #
Line 1528: # @supportedRHEVMs: A list of supported ovirt-engine versions
I know this part is tricky, but do we want to use RHEV here or supported_engines? And what
will you do with RHEV-3.1 which will be more like oVirt-3.2 than oVirt 3.1. Maybe it would
be good to use full names so supported_engines=['RHEV-M-3.1',
'ovirt-engine-3.1', 'ovirt-engine-3.2']?
Line 1529: #
Line 1530: # @supportedProtocols: A list of supported xmlrpc protocol versions
Line 1531: #
Line 1532: # @clusterLevels: A list of supported cluster versions
Line 1526: # @software_revision: Extra VDSM version information
Line 1527: #
Line 1528: # @supportedRHEVMs: A list of supported ovirt-engine versions
Line 1529: #
Line 1530: # @supportedProtocols: A list of supported xmlrpc protocol versions
I don't like mixing camelCase and under_scores.
Line 1531: #
Line 1532: # @clusterLevels: A list of supported cluster versions
Line 1533: #
Line 1534: # Since: 4.10.1
--
To view, visit http://gerrit.ovirt.org/8431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f55ef437ca404ca04598d34c41756b1e68ced95
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>