Yaniv Bronhaim has posted comments on this change.
Change subject: Distribute /var/log/core with vdsm rpm.
......................................................................
Patch Set 4:
(1 comment)
....................................................
File vdsm.spec.in
Line 617: install -Dm 0644 init/systemd/vdsm-tmpfiles.d.conf \
Line 618: %{buildroot}%{_tmpfilesdir}/%{vdsm_name}.conf
Line 619: %endif
Line 620:
Line 621: %if 0%{?rhel}
so should be if not..but why this condition exists anyway? remove the if and put also this
sample install above
Line 622: # Install the configuration sample
Line 623: install -Dm 0644 lib/vdsm/vdsm.conf.sample \
Line 624: %{buildroot}%{_sysconfdir}/vdsm/vdsm.conf
Line 625: %endif
--
To view, visit
http://gerrit.ovirt.org/22211
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7246b4947c0cdb52093c5fe0f60a690d72b1236
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes