Change in vdsm[master]: vm: per-attribute monitor response check
Nir Soffer has posted comments on this change.
Change subject: vm: per-attribute monitor response check
......................................................................
Patch Set 4:
(2 comments)
Following your verification, I think we would like log messages when we move between
normal and "bad" state. This can make it easier to grok the logs without using
special scripts (.e.g "When these timeouts were started?").
Note that since I did not spent much time groking this area, and my advice may be wrong.
http://gerrit.ovirt.org/#/c/23138/4/vdsm/vm.py
File vdsm/vm.py:
Line 3635:
Line 3636: def _timeoutExperienced(self, timeout, attrName):
Line 3637: with self._attributeTimeoutsLock:
Line 3638: if timeout:
Line 3639: self._attributeTimeouts.add(attrName)
If this is the first timeout added - moving from normal state to bad state, we need here a
info message in the log.
wasEmpty = len(self._attributeTimeouts) == 0
self._attributeTimeouts.add(attrName)
if wasEmpty:
self.log.info("entering abnormal state...")
Line 3640: elif attrName in self._attributeTimeouts:
Line 3641: self._attributeTimeouts.remove(attrName)
Line 3642:
Line 3643: @property
Line 3637: with self._attributeTimeoutsLock:
Line 3638: if timeout:
Line 3639: self._attributeTimeouts.add(attrName)
Line 3640: elif attrName in self._attributeTimeouts:
Line 3641: self._attributeTimeouts.remove(attrName)
If this is the last timeout removed - moving from bad state to normal state, we need here
a info message in the log.
self._attributeTimeouts.remove(attrName)
if len(self._attributeTimeouts) == 0:
self.log.info("ending abnormal state...")
Line 3642:
Line 3643: @property
Line 3644: def monitorResponse(self):
Line 3645: with self._attributeTimeoutsLock:
--
To view, visit http://gerrit.ovirt.org/23138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32a98d34cde91fa9dc3d07f03c47a5f2f22da620
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes