Mark Wu has posted comments on this change.
Change subject: Introduce API getBalloonInfo and setBalloonTarget
......................................................................
Patch Set 4: (1 inline comment)
Yes, setBalloonTarget only works with a virtio balloon device is added to the target
guest. That's why I sent a mail do discuss reserve the balloon device created by
libvirt. I will add this note to the commit message.
....................................................
File vdsm/libvirtvm.py
Line 2104: except libvirt.libvirtError:
oops! I will fix it in next version. Thanks!
--
To view, visit
http://gerrit.ovirt.org/3669
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b1211dbce28bb5bb5926f2db7e2e42a698efc9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>