Ayal Baron has posted comments on this change.
Change subject: Remove block size validation from blockSD instatiation.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 406: # *blkSize keys may be missing from metadata only for domains that
Line 407: # existed before the introduction of the keys.
Line 408: # Such domains supported only 512 sizes
Line 409: self.logBlkSize = 512
Line 410: self.phyBlkSize = 512
this change will not fix the underlying state of the PVs in the lvm cache which are not
linked to the VG, right?
Line 411:
Line 412: # _extendlock is used to prevent race between
Line 413: # VG extend and LV extend.
Line 414: self._extendlock = threading.Lock()
--
To view, visit
http://gerrit.ovirt.org/14514
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I296b4bd3a697078c89451b167b1f9e0f64cc015e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server