Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
......................................................................
Patch Set 16:
(1 comment)
http://gerrit.ovirt.org/#/c/25976/16/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 409: self._lowmark = None
Line 410:
Line 411: while not self._stop.isSet():
Line 412: self._stop.wait(MonitorThread._MONITOR_TICK)
Line 413: if self.enabled:
self.enabled is a constant - why is it tested repeatedly within the thread? Why wake up
every second to do nothing?
Line 414: self.monitor_migration(step)
Line 415: step += 1
Line 416:
Line 417: self._vm.log.debug('migration monitor thread exiting')
--
To view, visit
http://gerrit.ovirt.org/25976
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes