From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: validateDirAccess: move to sdperm
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/73115/2/lib/vdsm/storage/sdperm.py
File lib/vdsm/storage/sdperm.py:
Line 28: from . import exception as se
Line 29: from . import outOfProcess
Line 30:
Line 31:
Line 32: def validate_dir_access(path):
fileUtils is helpers for file storage domains.
From what you
describe, it still seems to me that Maor's fsutil is not likely to use high-level
entities like supervdsm or outOfProcess. fsutils should be small and agile and
low-level-ish.
Thus I'm not sure that validate_dir_access belongs there.
I'd prefer to keep this ugly function in a high-level module, which knows about
storage domains structure and "business logic" - but that can be placed under
lib/vdsm/storage right now. Should I call it sdperm, or sd_permissions or sd_access ?
Line 33: """verify that path's permissions match those of a file
storage domain"""
Line 34: try:
Line 35: outOfProcess.getGlobalProcPool().fileUtils.validateAccess(path)
Line 36: supervdsm.getProxy().validateAccess(
--
To view, visit
https://gerrit.ovirt.org/73115
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21ead1cb635f8224cb09f7319ffcb55eebe2a9e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes