From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: split functions by logic and few nits
......................................................................
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/70825/14/automation/check-merged.sh
File automation/check-merged.sh:
Line 1: #!/bin/bash -x
I know, that's how I prefer to run this script, otherwise it
exits and its
Running bash without -e is just like writing Python with
try:
statement
except:
pass
around each statement. It's a great way to quickly generate code with undetected
bugs.
non-trivial code must not use it.
Line 2:
Line 3: export LIBGUESTFS_BACKEND=direct
Line 4:
Line 5: # ensure /dev/kvm exists, otherwise it will still use
--
To view, visit
https://gerrit.ovirt.org/70825
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74f9326289b972abaef4507ab4d2582a8d641778
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes