From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: split functions by logic and few nits
......................................................................
Patch Set 11: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/70825/11/automation/check-merged.sh
File automation/check-merged.sh:
Line 5: # ensure /dev/kvm exists, otherwise it will still use
Line 6: # direct backend, but without KVM(much slower).
Line 7: ! [[ -c "/dev/kvm" ]] && mknod /dev/kvm c 10 232
Line 8:
Line 9: # Fix when running in an el* chroot in fc2* host
comment still not readable
Line 10: [[ -e /usr/bin/qemu-kvm ]] \
Line 11: || ln -s /usr/libexec/qemu-kvm /usr/bin/qemu-kvm
Line 12:
Line 13: # ENV vars
PS11, Line 96: ret
other functions call it res
PS11, Line 110: failed
why not stay with "res"?
PS11, Line 113: res
always declare as local
PS11, Line 138: if [ $? -ne 0 ]; then
: echo 'check-merged.sh: ERROR during setup_env'
: exit 1
: fi
again, with -e, this could would never be reached.
--
To view, visit
https://gerrit.ovirt.org/70825
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74f9326289b972abaef4507ab4d2582a8d641778
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes