Federico Simoncelli has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
....................................................
File vdsm/vm.py
Line 2451: 'message': 'Machine shut down'}}
Line 2452:
Line 2453: def pmWakeup(self):
Line 2454: try:
Line 2455: self._connection.virDomainPMWakeup()
shouldn't this be something like:
self._dom.pMWakeup(...)
Line 2456: except:
Line 2457: self.log.error("Wake up failed", exc_info=True)
Line 2458: return {'status': {'code':
errCode['exist']['status']['code'],
Line 2459: 'message': 'Failed to wake up VM.'}}
Line 2465: targets = {'mem': libvirt.VIR_NODE_SUSPEND_TARGET_MEM,
Line 2466: 'disk': libvirt.VIR_NODE_SUSPEND_TARGET_DISK,
Line 2467: 'hybrid':
libvirt.VIR_NODE_SUSPEND_TARGET_HYBRID}
Line 2468:
Line 2469: self._connection.virDomainPMSuspendForDuration(targets[target],
shouldn't this be something like:
self._dom.pMSuspendForDuration(...)
Line 2470: 0, 0)
Line 2471: except:
Line 2472: self.log.error("Suspend failed", exc_info=True)
Line 2473: return {'status': {'code':
errCode['exist']['status']['code'],
--
To view, visit
http://gerrit.ovirt.org/19389
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes