Federico Simoncelli has posted comments on this change.
Change subject: sp: improve pool creation error handling
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/storage/sp.py
Line 620: # lock
Line 621: # TBD: create will receive only master domain and further attaches
Line 622: # should be done under SPM
Line 623: try:
Line 624: for sdUUID in domList:
I'm not sure when that was introduced but currently it does (Attach Data =>
multiple checkboxes => createStoragePool with multiple domains)
Line 625: # Master domain was already attached (in createMaster)
Line 626: if sdUUID != msdUUID:
Line 627: self.attachSD(sdUUID)
Line 628: except Exception:
--
To view, visit
http://gerrit.ovirt.org/22818
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cce08e368dec092222c081609d0663d7990ab10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes