Adam Litke has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
......................................................................
Patch Set 7: (1 inline comment)
Hi Gal, we are in the process of formalizing the API with a schema (see
vdsm_api/vdsmapi-schema.json). Since your patch modifies the API you will have to modify
the API schema accordingly.
You have to modify the VM.hibernate command definition to account for the expanded set of
values allowed in the target parameter.
Your API change essentially defines the 'target' parameter as a new union type.
It can be either a HibernationVolumeHandle (string) or a HibernationMode (enum).
So you need to create the HibernationMode enum (containing 'disk' and
'memory') and a HibernationTarget union that can be either a HibernationMode or a
HibernationVolumeHandle. Then change the VM.Hibernate command definition to reflect the
changes in the types as well.
....................................................
File vdsm/BindingXMLRPC.py
Line 322: def vmHibernate(self, vmId, target='disk'):
target=<...>.DISK in order to use your new class definition
--
To view, visit
http://gerrit.ovirt.org/1121
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>