Shireesh Anjal has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/taskManager.py
Line 193: elif 'gluster' in tag:
Line 194: subRes.update(self._getAllGlusterTasks())
Line 195: except ge.GlusterException:
Line 196: self.log.error("gluster exception occured",
exc_info=True)
Line 197:
To elaborate a little on Bala's statement, gluster tasks are a bit different in the
sense they can be started on any server of the cluster, and later their status can be
checked on any other server of the cluster, using the gluster CLI. So we can't rely on
self._tasks for gluster tasks, when returning task statuses. This, I believe is unique to
gluster and probably deserves to be handled in a special way.
Having said this, please do suggest if you have a better way of doing this, and I'm
sure Bala will be more than happy to implement it :)
Line 198: self.log.debug("Return: %s", subRes)
Line 199: return subRes
Line 200:
Line 201: def unloadTasks(self, tag=None):
--
To view, visit
http://gerrit.ovirt.org/7579
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c765cbfebb5ba22f0d21efa04c824ea4daf6432
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server