Liron Ar has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/tests/resourceManagerTests.py
File tests/resourceManagerTests.py:
Line 499: res1.release()
Line 500: res2.release()
Line 501:
Line 502: def testAcquireResourceFailureExclusive(self):
Line 503: self.assertAcquireResourceFails("string", "test",
Good idea for another patch - this strings are used all over this
file.
I'd at least add those in this patch and in later patch we could change
the whole file. but whatever you prefer.
Line 504: resourceManager.LockType.exclusive)
Line 505: self.assertCanAcquireResource("string", "test")
Line 506:
Line 507: def testAcquireResourceFailureExclusiveShared(self):
--
To view, visit
http://gerrit.ovirt.org/25284
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes