Saggi Mizrahi has posted comments on this change.
Change subject: Move fencing logic out of API.py
......................................................................
Patch Set 7:
(1 comment)
test
....................................................
File vdsm/fenceAgent.py
Line 60: 'passwd=%s\n') % (agent, addr, username, action, password)
Line 61:
Line 62: if bladePort:
Line 63: inp += 'port=%d\n' % (bladePort,)
Line 64:
it can't be passthrough anymore, we're going typesafe :).
I'll just have it be a string.
Line 65: if secure:
Line 66: inp += 'secure=yes\n'
Line 67:
Line 68: inp += options
--
To view, visit
http://gerrit.ovirt.org/7190
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes