Michal Skrivanek has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
......................................................................
Patch Set 38: Code-Review-1
(1 comment)
I'm still not happy with the version check…
for abort_on_eio it makes sense as it was fixing the already broken.
but here introducing a tiny little feature and blocking 3.5 cluster level because of
it…doesn't sound right to me
http://gerrit.ovirt.org/#/c/26917/38/vdsm/caps.py
File vdsm/caps.py:
Line 589: logging.error('libvirt does not support the SPICE control'
Line 590: ' features, (file transfer disable), support'
Line 591: ' for clusterLevel >= 3.5 is disabled.'
Line 592: ' Consider upgrading to libvirt >= 1.2.2')
Line 593: maxClusterVer = '3.5'
I'd use 3.4 and 3.3 below and change the comparison accordingly @577
Would make it more obvious…:)
Line 594: if not hasattr(libvirt, 'VIR_MIGRATE_ABORT_ON_ERROR'):
Line 595: logging.error('VIR_MIGRATE_ABORT_ON_ERROR not found in
libvirt,'
Line 596: ' support for clusterLevel >= 3.4 is
disabled.'
Line 597: ' For Fedora 19 users, please consider upgrading'
--
To view, visit
http://gerrit.ovirt.org/26917
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc98a346baca4ab163ff30e891ae80535e49caa4
Gerrit-PatchSet: 38
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes