Ayal Baron has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 11: Code-Review-1
(1 comment)
selinux policy was released.
still need to address the remaining comments
....................................................
File vdsm/clientIF.py
Line 255: if res['status']['code']:
Line 256: raise vm.VolumeError(drive)
Line 257:
Line 258: volPath = res['path']
Line 259: # res['imgVolumesInfo'] is in arbitary order
s/is in arbitary/order of imgVokumesInfo is not guaranteed/
Line 260: drive['volumeChain'] = res['imgVolumesInfo']
Line 261: drive['volumeInfo'] = res['info']
Line 262:
Line 263: # GUID drive format
--
To view, visit
http://gerrit.ovirt.org/4220
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990(a)gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes