Change in vdsm[master]: build: add flag to choose ssl implementation
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: build: add flag to choose ssl implementation
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/72272/6/vdsm.spec.in
File vdsm.spec.in:
Line 729: sed -i -e 's/^software_version =.*/software_version =
"'"${baseversion}"'"/' \
Line 730: -e 's/^raw_version_revision =.*/raw_version_revision =
"'"${rawversion}"'"/' \
Line 731: -e 's/^software_revision =.*/software_revision =
"'"${baserelease}"'"/' lib/vdsm/dsaversion.py
Line 732:
Line 733: sed -i -e 's/@SSL_IMPLEMENTATION@/%{ssl_implementation}/g'
lib/vdsm/config.py
You have just introduced this piece of code to Makefile.am. There is no need to keep it
here as well.
But actually, it would be more fitting to set AC_SUBST([SSL_IMPLEMENTATION], ...) in
configure.ac
autoconf resembles witchcraft, but using it is better than piling our own scripts on top
of what we currently have.
Line 734:
Line 735: sed -i -e 's\@VDSMRPCPYLIBDIR@\%{python_sitelib}/%{vdsm_name}/rpc\g'
lib/vdsm/constants.py
Line 736:
Line 737: %install
--
To view, visit https://gerrit.ovirt.org/72272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06232c8917f620686887a8b07a17608cfb70ef27
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes