From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move hooks to common
......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/79695/12/lib/vdsm/common/hook/hooking.py
File lib/vdsm/common/hook/hooking.py:
Line 41: import os
Line 42: import sys
Line 43: from xml.dom import minidom
Line 44:
Line 45: from vdsm.commands import execCmd
common package should not depend on the vdsm package.
Ouch. I
wonder how I failed to notice this. execCmd is exposed to hooks (one hook is even using
sync=False!), so we cannot easily avoid having it in common.
Line 46: from vdsm.common.conv import tobool
Line 47: from vdsm.common import hooks
Line 48:
Line 49: # make pyflakes happy
--
To view, visit
https://gerrit.ovirt.org/79695
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4be8e8b2418ea758047234c5ae061dc5134bc0da
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes