Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
......................................................................
Patch Set 18:
clarified the units; Explained previously while I don't think the division by zero is
a real problem (there is an check before this code which will ensure the divisor being
> 0)
Checked AdvancedStats*. It is indeed quite similar to this use case, but still different
enough to deserve some preparation work which I don't feel is useful for this
patchset.
I'm exploring a bit more generic concept in my upcoming threadpool patchset, we can
port this code on top of that in a later patch.
--
To view, visit
http://gerrit.ovirt.org/25976
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No