From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: LeakedThreadsPlugin
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/69040/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-12-29 16:18:51 +0200
Line 6:
Line 7: tests: CountThreadsPlugin
Line 8:
Line 9: Enable this test plugin (via --with-countthreads) to verify that neither
what about --count-leaked-threads?
I really prefer to stick
with nose's default naming (--with-plugin-name).
Line 10: your test, nor the code it tests, leak threads. Unfortunately, this
Line 11: plugin cannot be enabled by default, since we do have buggy test and
Line 12: code that do leak.
Line 13:
--
To view, visit
https://gerrit.ovirt.org/69040
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4347f5a6ccf02e80d86174c979eb85a0c5076e7a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes