Antoni Segura Puimedon has posted comments on this change.
Change subject: faqemu: move hook logic out of vdsm
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/27705/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: faqemu: move hook logic out of vdsm
Line 8:
Line 9: Vdsm-proper has been aware of the faqemu hook. Now that we have an
Line 10: after_get_caps hook point, this is no longer necessary. This patch move
s/move/moves/
Line 11: the faking logic, so that it does not need to be shipped on production
Line 12: systems and clutter the code.
Line 13:
Line 14: Change-Id: I46d0079491f707b0abd3fbbe2d47f63697dac9c5
http://gerrit.ovirt.org/#/c/27705/1/vdsm/caps.py
File vdsm/caps.py:
Line 294: return AutoNumaBalancingStatus.UNKNOWN
Line 295:
Line 296:
Line 297: @utils.memoized
Line 298: def getEmulatedMachines(arch, capabilities=None):
A more picky man would say that these two name changes are not material to this changeset
:P. It's fine and more consistent though.
Line 299: if capabilities is None:
Line 300: capabilities = _getCapsXMLStr()
Line 301: caps = minidom.parseString(capabilities)
Line 302:
http://gerrit.ovirt.org/#/c/27705/1/vdsm_hooks/faqemu/after_get_caps.py
File vdsm_hooks/faqemu/after_get_caps.py:
Line 26: # using vdsm internals in a hook is dangerous and frowned upon,
Line 27: # as internal APIs may change without notice.
Line 28: # However, faqemu is a bit different, as it is not expected to be ever used in
Line 29: # production.
Line 30: sys.path.append('/usr/share/vdsm')
I think this should be filled by make somehow.
It should be
exposed through hooking. As in:
from hooking import caps
Line 31: import caps
Line 32: import hooking
Line 33: from vdsm.config import config
Line 34:
--
To view, visit
http://gerrit.ovirt.org/27705
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46d0079491f707b0abd3fbbe2d47f63697dac9c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes